From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: alexei.starovoitov@gmail.com, daniel@iogearbox.net,
brouer@redhat.com, "Björn Töpel" <bjorn.topel@intel.com>,
"Magnus Karlsson" <magnus.karlsson@intel.com>
Cc: oss-drivers@netronome.com, netdev@vger.kernel.org,
Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: [RFC bpf-next 0/6] net: xsk: minor improvements around queue handling
Date: Thu, 26 Jul 2018 14:41:42 -0700 [thread overview]
Message-ID: <20180726214148.2087-1-jakub.kicinski@netronome.com> (raw)
Hi!
This set tries to make the core take care of error checking for the
drivers. In particular making sure that the AF_XDP UMEM is not installed
on queues which don't exist (or are disabled) and that changing queue
(AKA ethtool channel) count cannot disable queues with active AF_XDF
zero-copy sockets.
I'm sending as an RFC because I'm not entirely sure what the desired
behaviour is here. Is it Okay to install AF_XDP on queues which don't
exist? I presume not? Are the AF_XDP queue_ids referring to TX queues
as well as RX queues in case of the driver? I presume not? Should
we try to prevent disabling queues which have non zero-copy sockets
installed as well? :S
Anyway, if any of those patches seem useful and reasonable, please let
me know I will repost as non-RFC.
Jakub Kicinski (6):
net: update real_num_rx_queues even when !CONFIG_SYSFS
xsk: refactor xdp_umem_assign_dev()
xsk: don't allow umem replace at stack level
xsk: don't allow installing UMEM beyond the number of queues
ethtool: rename local variable max -> curr
ethtool: don't allow disabling queues with umem installed
include/linux/netdevice.h | 16 +++++++--
net/core/ethtool.c | 19 ++++++----
net/xdp/xdp_umem.c | 73 ++++++++++++++++++++++++---------------
3 files changed, 71 insertions(+), 37 deletions(-)
--
2.17.1
next reply other threads:[~2018-07-26 23:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 21:41 Jakub Kicinski [this message]
2018-07-26 21:41 ` [RFC bpf-next 1/6] net: update real_num_rx_queues even when !CONFIG_SYSFS Jakub Kicinski
2018-07-26 21:41 ` [RFC bpf-next 2/6] xsk: refactor xdp_umem_assign_dev() Jakub Kicinski
2018-07-30 11:41 ` Björn Töpel
2018-07-26 21:41 ` [RFC bpf-next 3/6] xsk: don't allow umem replace at stack level Jakub Kicinski
2018-07-30 12:00 ` Björn Töpel
2018-07-26 21:41 ` [RFC bpf-next 4/6] xsk: don't allow installing UMEM beyond the number of queues Jakub Kicinski
2018-07-26 21:41 ` [RFC bpf-next 5/6] ethtool: rename local variable max -> curr Jakub Kicinski
2018-07-26 21:41 ` [RFC bpf-next 6/6] ethtool: don't allow disabling queues with umem installed Jakub Kicinski
2018-07-30 12:49 ` [RFC bpf-next 0/6] net: xsk: minor improvements around queue handling Björn Töpel
2018-07-31 2:49 ` Jakub Kicinski
2018-07-31 7:15 ` Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726214148.2087-1-jakub.kicinski@netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).