From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: alexei.starovoitov@gmail.com, daniel@iogearbox.net,
brouer@redhat.com, "Björn Töpel" <bjorn.topel@intel.com>,
"Magnus Karlsson" <magnus.karlsson@intel.com>
Cc: oss-drivers@netronome.com, netdev@vger.kernel.org,
Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: [RFC bpf-next 1/6] net: update real_num_rx_queues even when !CONFIG_SYSFS
Date: Thu, 26 Jul 2018 14:41:43 -0700 [thread overview]
Message-ID: <20180726214148.2087-2-jakub.kicinski@netronome.com> (raw)
In-Reply-To: <20180726214148.2087-1-jakub.kicinski@netronome.com>
We used to depend on real_num_rx_queues as a upper bound for sanity
checks. For AF_XDP it's useful if drivers can trust the stack never
to try to install UMEM for queues which are not configured. Update
dev->real_num_rx_queues even without sysfs compiled, otherwise it
would always stay equal dev->num_rx_queues.
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
---
include/linux/netdevice.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index c1295c7a452e..6717dc7e8fbf 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -3433,6 +3433,7 @@ int netif_set_real_num_rx_queues(struct net_device *dev, unsigned int rxq);
static inline int netif_set_real_num_rx_queues(struct net_device *dev,
unsigned int rxq)
{
+ dev->real_num_rx_queues = rxqs;
return 0;
}
#endif
--
2.17.1
next prev parent reply other threads:[~2018-07-26 23:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 21:41 [RFC bpf-next 0/6] net: xsk: minor improvements around queue handling Jakub Kicinski
2018-07-26 21:41 ` Jakub Kicinski [this message]
2018-07-26 21:41 ` [RFC bpf-next 2/6] xsk: refactor xdp_umem_assign_dev() Jakub Kicinski
2018-07-30 11:41 ` Björn Töpel
2018-07-26 21:41 ` [RFC bpf-next 3/6] xsk: don't allow umem replace at stack level Jakub Kicinski
2018-07-30 12:00 ` Björn Töpel
2018-07-26 21:41 ` [RFC bpf-next 4/6] xsk: don't allow installing UMEM beyond the number of queues Jakub Kicinski
2018-07-26 21:41 ` [RFC bpf-next 5/6] ethtool: rename local variable max -> curr Jakub Kicinski
2018-07-26 21:41 ` [RFC bpf-next 6/6] ethtool: don't allow disabling queues with umem installed Jakub Kicinski
2018-07-30 12:49 ` [RFC bpf-next 0/6] net: xsk: minor improvements around queue handling Björn Töpel
2018-07-31 2:49 ` Jakub Kicinski
2018-07-31 7:15 ` Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726214148.2087-2-jakub.kicinski@netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).