From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: amd: pcnet32: Replace GFP_ATOMIC with GFP_KERNEL in pcnet32_alloc_ring() Date: Fri, 27 Jul 2018 14:11:48 -0700 (PDT) Message-ID: <20180727.141148.820276355416116908.davem@davemloft.net> References: <20180727075758.2516-1-baijiaju1990@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: pcnet32@frontier.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: baijiaju1990@gmail.com Return-path: In-Reply-To: <20180727075758.2516-1-baijiaju1990@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Jia-Ju Bai Date: Fri, 27 Jul 2018 15:57:58 +0800 > pcnet32_alloc_ring() is never called in atomic context. > It calls kcalloc() with GFP_ATOMIC, which is not necessary. > GFP_ATOMIC can be replaced with GFP_KERNEL. > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai Applied.