From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: usb: pegasus: Replace mdelay() with msleep() in setup_pegasus_II() Date: Fri, 27 Jul 2018 14:12:49 -0700 (PDT) Message-ID: <20180727.141249.2268355680445612136.davem@davemloft.net> References: <20180727083629.18663-1-baijiaju1990@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: petkan@nucleusys.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: baijiaju1990@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:39186 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389373AbeG0Wge (ORCPT ); Fri, 27 Jul 2018 18:36:34 -0400 In-Reply-To: <20180727083629.18663-1-baijiaju1990@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jia-Ju Bai Date: Fri, 27 Jul 2018 16:36:29 +0800 > setup_pegasus_II() is never called in atomic context. > It calls mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep(). > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai Applied.