From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: tipc: bcast: Replace GFP_ATOMIC with GFP_KERNEL in tipc_bcast_init() Date: Fri, 27 Jul 2018 14:13:13 -0700 (PDT) Message-ID: <20180727.141313.1728041732656571923.davem@davemloft.net> References: <20180727093135.7469-1-baijiaju1990@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jon.maloy@ericsson.com, ying.xue@windriver.com, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org To: baijiaju1990@gmail.com Return-path: In-Reply-To: <20180727093135.7469-1-baijiaju1990@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Jia-Ju Bai Date: Fri, 27 Jul 2018 17:31:35 +0800 > tipc_bcast_init() is never called in atomic context. > It calls kzalloc() with GFP_ATOMIC, which is not necessary. > GFP_ATOMIC can be replaced with GFP_KERNEL. > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai Applied.