From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jia-Ju Bai Subject: [PATCH] net: phy: marvell: Replace mdelay() with msleep() in m88e1116r_config_init() Date: Fri, 27 Jul 2018 16:34:25 +0800 Message-ID: <20180727083425.14481-1-baijiaju1990@gmail.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai To: andrew@lunn.ch, f.fainelli@gmail.com Return-path: Received: from mail-pl0-f67.google.com ([209.85.160.67]:35918 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729420AbeG0JzW (ORCPT ); Fri, 27 Jul 2018 05:55:22 -0400 Sender: netdev-owner@vger.kernel.org List-ID: m88e1116r_config_init() is never called in atomic context. It calls mdelay() to busily wait, which is not necessary. mdelay() can be replaced with msleep(). This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai --- drivers/net/phy/marvell.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index 25e2a099b71c..ed04346df235 100644 --- a/drivers/net/phy/marvell.c +++ b/drivers/net/phy/marvell.c @@ -646,7 +646,7 @@ static int m88e1116r_config_init(struct phy_device *phydev) if (err < 0) return err; - mdelay(500); + msleep(500); err = marvell_set_page(phydev, MII_MARVELL_COPPER_PAGE); if (err < 0) -- 2.17.0