* [PATCH] net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind()
@ 2018-07-27 8:41 Jia-Ju Bai
2018-07-27 9:04 ` liujunliang_ljl
2018-07-27 21:12 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jia-Ju Bai @ 2018-07-27 8:41 UTC (permalink / raw)
To: liujunliang_ljl; +Cc: linux-usb, netdev, linux-kernel, Jia-Ju Bai
sr9700_bind() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
drivers/net/usb/sr9700.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c
index 2d316c1b851b..6ac232e52bf7 100644
--- a/drivers/net/usb/sr9700.c
+++ b/drivers/net/usb/sr9700.c
@@ -358,7 +358,7 @@ static int sr9700_bind(struct usbnet *dev, struct usb_interface *intf)
/* power up and reset phy */
sr_write_reg(dev, SR_PRR, PRR_PHY_RST);
/* at least 10ms, here 20ms for safe */
- mdelay(20);
+ msleep(20);
sr_write_reg(dev, SR_PRR, 0);
/* at least 1ms, here 2ms for reading right register */
udelay(2 * 1000);
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind()
2018-07-27 8:41 [PATCH] net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind() Jia-Ju Bai
@ 2018-07-27 9:04 ` liujunliang_ljl
2018-07-27 21:12 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: liujunliang_ljl @ 2018-07-27 9:04 UTC (permalink / raw)
To: Jia-Ju Bai; +Cc: linux-usb, netdev, linux-kernel, Jia-Ju Bai
[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]
Dear Jia-Ju Bai :
OK.
the patch is ok.
liujunliang_ljl@163.com
From: Jia-Ju Bai
Date: 2018-07-27 16:41
To: liujunliang_ljl
CC: linux-usb; netdev; linux-kernel; Jia-Ju Bai
Subject: [PATCH] net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind()
sr9700_bind() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
drivers/net/usb/sr9700.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c
index 2d316c1b851b..6ac232e52bf7 100644
--- a/drivers/net/usb/sr9700.c
+++ b/drivers/net/usb/sr9700.c
@@ -358,7 +358,7 @@ static int sr9700_bind(struct usbnet *dev, struct usb_interface *intf)
/* power up and reset phy */
sr_write_reg(dev, SR_PRR, PRR_PHY_RST);
/* at least 10ms, here 20ms for safe */
- mdelay(20);
+ msleep(20);
sr_write_reg(dev, SR_PRR, 0);
/* at least 1ms, here 2ms for reading right register */
udelay(2 * 1000);
--
2.17.0
[-- Attachment #2: Type: text/html, Size: 3544 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind()
2018-07-27 8:41 [PATCH] net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind() Jia-Ju Bai
2018-07-27 9:04 ` liujunliang_ljl
@ 2018-07-27 21:12 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-07-27 21:12 UTC (permalink / raw)
To: baijiaju1990; +Cc: liujunliang_ljl, linux-usb, netdev, linux-kernel
From: Jia-Ju Bai <baijiaju1990@gmail.com>
Date: Fri, 27 Jul 2018 16:41:04 +0800
> sr9700_bind() is never called in atomic context.
> It calls mdelay() to busily wait, which is not necessary.
> mdelay() can be replaced with msleep().
>
> This is found by a static analysis tool named DCNS written by myself.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-27 21:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-27 8:41 [PATCH] net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind() Jia-Ju Bai
2018-07-27 9:04 ` liujunliang_ljl
2018-07-27 21:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).