From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH net-next 1/3] failover: change mtu has RTNL Date: Fri, 27 Jul 2018 13:43:21 -0700 Message-ID: <20180727204323.19408-2-sthemmin@microsoft.com> References: <20180727204323.19408-1-sthemmin@microsoft.com> Cc: Stephen Hemminger , Stephen Hemminger To: netdev@vger.kernel.org Return-path: Received: from mail-pf1-f193.google.com ([209.85.210.193]:35052 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389266AbeG0WHE (ORCPT ); Fri, 27 Jul 2018 18:07:04 -0400 Received: by mail-pf1-f193.google.com with SMTP id q7-v6so2110217pff.2 for ; Fri, 27 Jul 2018 13:43:30 -0700 (PDT) In-Reply-To: <20180727204323.19408-1-sthemmin@microsoft.com> Sender: netdev-owner@vger.kernel.org List-ID: When changing MTU, RTNL is held so use rtnl_dereference instead of rcu_dereference. Signed-off-by: Stephen Hemminger --- drivers/net/net_failover.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c index d00d42c845b7..7ae1856d1f18 100644 --- a/drivers/net/net_failover.c +++ b/drivers/net/net_failover.c @@ -220,14 +220,14 @@ static int net_failover_change_mtu(struct net_device *dev, int new_mtu) struct net_device *primary_dev, *standby_dev; int ret = 0; - primary_dev = rcu_dereference(nfo_info->primary_dev); + primary_dev = rtnl_dereference(nfo_info->primary_dev); if (primary_dev) { ret = dev_set_mtu(primary_dev, new_mtu); if (ret) return ret; } - standby_dev = rcu_dereference(nfo_info->standby_dev); + standby_dev = rtnl_dereference(nfo_info->standby_dev); if (standby_dev) { ret = dev_set_mtu(standby_dev, new_mtu); if (ret) { -- 2.18.0