From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: oss-drivers@netronome.com, netdev@vger.kernel.org,
john.hurley@netronome.com
Subject: Re: [PATCH net] nfp: flower: fix port metadata conversion bug
Date: Sat, 28 Jul 2018 14:28:06 -0700 (PDT) [thread overview]
Message-ID: <20180728.142806.240219202550083982.davem@davemloft.net> (raw)
In-Reply-To: <20180728035652.22604-1-jakub.kicinski@netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Fri, 27 Jul 2018 20:56:52 -0700
> From: John Hurley <john.hurley@netronome.com>
>
> Function nfp_flower_repr_get_type_and_port expects an enum nfp_repr_type
> return value but, if the repr type is unknown, returns a value of type
> enum nfp_flower_cmsg_port_type. This means that if FW encodes the port
> ID in a way the driver does not understand instead of dropping the frame
> driver may attribute it to a physical port (uplink) provided the port
> number is less than physical port count.
>
> Fix this and ensure a net_device of NULL is returned if the repr can not
> be determined.
>
> Fixes: 1025351a88a4 ("nfp: add flower app")
> Signed-off-by: John Hurley <john.hurley@netronome.com>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> ---
> This is low impact and unlikely, but also fix is trivial so either
> net or net-next works.
Applied to 'net', thanks.
prev parent reply other threads:[~2018-07-28 22:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-28 3:56 [PATCH net] nfp: flower: fix port metadata conversion bug Jakub Kicinski
2018-07-28 21:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180728.142806.240219202550083982.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=john.hurley@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox