From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] ipv4: remove BUG_ON() from fib_compute_spec_dst Date: Sat, 28 Jul 2018 19:07:02 -0700 (PDT) Message-ID: <20180728.190702.1921184748389867883.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: lorenzo.bianconi@redhat.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:59846 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731606AbeG2Dfl (ORCPT ); Sat, 28 Jul 2018 23:35:41 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Lorenzo Bianconi Date: Fri, 27 Jul 2018 18:15:46 +0200 > Remove BUG_ON() from fib_compute_spec_dst routine and check > in_dev pointer during flowi4 data structure initialization. > fib_compute_spec_dst routine can be run concurrently with device removal > where ip_ptr net_device pointer is set to NULL. This can happen > if userspace enables pkt info on UDP rx socket and the device > is removed while traffic is flowing > > Fixes: 35ebf65e851c ("ipv4: Create and use fib_compute_spec_dst() helper") > Signed-off-by: Lorenzo Bianconi Applied and queued up for -stable, thank you.