From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] virtio_net: force_napi_tx module param. Date: Sun, 29 Jul 2018 13:36:36 -0700 (PDT) Message-ID: <20180729.133636.8234343672255084.davem@davemloft.net> References: <20180723231119.142904-1-caleb.raitto@gmail.com> <20180729.090027.1373538625446665385.davem@davemloft.net> <20180729231247-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: caleb.raitto@gmail.com, jasowang@redhat.com, netdev@vger.kernel.org, caraitto@google.com To: mst@redhat.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:44720 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726795AbeG2WIW (ORCPT ); Sun, 29 Jul 2018 18:08:22 -0400 In-Reply-To: <20180729231247-mutt-send-email-mst@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: From: "Michael S. Tsirkin" Date: Sun, 29 Jul 2018 23:33:20 +0300 > The point really is that tx irq handler needs a lock on the tx queue to > free up skbs, so processing it on another CPU while tx is active causes > cache line bounces. So we want affinity to CPUs that submit to this > queue on the theory they have these cache line(s) anyway. > > I suspect it's not a uniqueue property of virtio. It certainly is not. I think the objectives are clear, someone just needs to put them together cleanly into a patch :)