From: David Miller <davem@davemloft.net>
To: rpjday@crashcourse.ca
Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com
Subject: Re: [PATCH] phy: Move "device present" masks earlier in file
Date: Mon, 30 Jul 2018 09:23:19 -0700 (PDT) [thread overview]
Message-ID: <20180730.092319.1806492645215935692.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.2.21.1807271526270.22062@localhost.localdomain>
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
Date: Fri, 27 Jul 2018 15:32:20 -0400 (EDT)
> Move the "device present" mask bits up immediately after the MMD
> device definitions, since it makes no sense to have them further down
> in the file.
>
> This is purely a cosmetic change for readability.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Sorry, but this actually kills readability.
This area of this header file is a series of collections of register
bit definitions. One for each register.
You are moving the device present register definitions out of that
area.
It makes no sense at all.
I'm not applying this, sorry.
prev parent reply other threads:[~2018-07-30 17:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 19:32 [PATCH] phy: Move "device present" masks earlier in file Robert P. J. Day
2018-07-30 16:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730.092319.1806492645215935692.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).