From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] phy: Move "device present" masks earlier in file Date: Mon, 30 Jul 2018 09:23:19 -0700 (PDT) Message-ID: <20180730.092319.1806492645215935692.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com To: rpjday@crashcourse.ca Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:60698 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726760AbeG3R7E (ORCPT ); Mon, 30 Jul 2018 13:59:04 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: "Robert P. J. Day" Date: Fri, 27 Jul 2018 15:32:20 -0400 (EDT) > Move the "device present" mask bits up immediately after the MMD > device definitions, since it makes no sense to have them further down > in the file. > > This is purely a cosmetic change for readability. > > Signed-off-by: Robert P. J. Day Sorry, but this actually kills readability. This area of this header file is a series of collections of register bit definitions. One for each register. You are moving the device present register definitions out of that area. It makes no sense at all. I'm not applying this, sorry.