From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: pabeni@redhat.com, netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, daniel@iogearbox.net,
marcelo.leitner@gmail.com, eyal.birger@gmail.com
Subject: Re: [PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT.
Date: Mon, 30 Jul 2018 09:31:00 -0700 (PDT) [thread overview]
Message-ID: <20180730.093100.1043667653536689097.davem@davemloft.net> (raw)
In-Reply-To: <20180730124013.GF2058@nanopsycho>
From: Jiri Pirko <jiri@resnulli.us>
Date: Mon, 30 Jul 2018 14:40:13 +0200
> Oh, another nitpick: The changelog should go under "---" line. That way,
> the maintainer does not have to deal with it during apply (git apply
> will cut it out).
I actually like the changelog to be _IN_ the commit message.
It's useful information that helps someone investigating history
in the tree later.
Please do not tell people to pull changelogs out of the commit
message, thank you. I've been telling them to do the exact
opposite.
next prev parent reply other threads:[~2018-07-30 18:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 12:30 [PATCH net-next v5 0/4] TC: refactor act_mirred packets re-injection Paolo Abeni
2018-07-30 12:30 ` [PATCH net-next v5 1/4] net/sched: user-space can't set unknown tcfa_action values Paolo Abeni
2018-07-30 12:36 ` Jiri Pirko
2018-07-30 14:03 ` Jamal Hadi Salim
2018-07-30 14:21 ` Jiri Pirko
2018-07-30 16:41 ` Paolo Abeni
2018-07-30 19:31 ` Jamal Hadi Salim
2018-07-31 9:41 ` Paolo Abeni
2018-07-31 13:53 ` Jamal Hadi Salim
2018-07-31 14:40 ` Paolo Abeni
2018-08-01 14:34 ` Jamal Hadi Salim
2018-07-30 12:30 ` [PATCH net-next v5 2/4] tc/act: remove unneeded RCU lock in action callback Paolo Abeni
2018-07-30 12:30 ` [PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT Paolo Abeni
2018-07-30 12:40 ` Jiri Pirko
2018-07-30 16:31 ` David Miller [this message]
2018-07-30 16:49 ` Jiri Pirko
2018-07-30 16:56 ` David Miller
2018-07-30 12:30 ` [PATCH net-next v5 4/4] act_mirred: use TC_ACT_REINSERT when possible Paolo Abeni
2018-07-30 12:42 ` Jiri Pirko
2018-07-30 16:31 ` [PATCH net-next v5 0/4] TC: refactor act_mirred packets re-injection David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730.093100.1043667653536689097.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@iogearbox.net \
--cc=eyal.birger@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).