From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT. Date: Mon, 30 Jul 2018 09:31:00 -0700 (PDT) Message-ID: <20180730.093100.1043667653536689097.davem@davemloft.net> References: <695eaa79e2c02c64f0daacd38c35c63bbdfee60f.1532934532.git.pabeni@redhat.com> <20180730124013.GF2058@nanopsycho> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: pabeni@redhat.com, netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, daniel@iogearbox.net, marcelo.leitner@gmail.com, eyal.birger@gmail.com To: jiri@resnulli.us Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:60932 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727667AbeG3SGr (ORCPT ); Mon, 30 Jul 2018 14:06:47 -0400 In-Reply-To: <20180730124013.GF2058@nanopsycho> Sender: netdev-owner@vger.kernel.org List-ID: From: Jiri Pirko Date: Mon, 30 Jul 2018 14:40:13 +0200 > Oh, another nitpick: The changelog should go under "---" line. That way, > the maintainer does not have to deal with it during apply (git apply > will cut it out). I actually like the changelog to be _IN_ the commit message. It's useful information that helps someone investigating history in the tree later. Please do not tell people to pull changelogs out of the commit message, thank you. I've been telling them to do the exact opposite.