From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v7] net/tls: Use socket data_ready callback on record availability Date: Mon, 30 Jul 2018 09:42:07 -0700 (PDT) Message-ID: <20180730.094207.1618887888310467887.davem@davemloft.net> References: <20180730103833.6585-1-vakul.garg@nxp.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, borisp@mellanox.com, aviadye@mellanox.com, davejwatson@fb.com To: vakul.garg@nxp.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:32922 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726760AbeG3SR5 (ORCPT ); Mon, 30 Jul 2018 14:17:57 -0400 In-Reply-To: <20180730103833.6585-1-vakul.garg@nxp.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Vakul Garg Date: Mon, 30 Jul 2018 16:08:33 +0530 > On receipt of a complete tls record, use socket's saved data_ready > callback instead of state_change callback. In function tls_queue(), > the TLS record is queued in encrypted state. But the decryption > happen inline when tls_sw_recvmsg() or tls_sw_splice_read() get invoked. > So it should be ok to notify the waiting context about the availability > of data as soon as we could collect a full TLS record. For new data > availability notification, sk_data_ready callback is more appropriate. > It points to sock_def_readable() which wakes up specifically for EPOLLIN > event. This is in contrast to the socket callback sk_state_change which > points to sock_def_wakeup() which issues a wakeup unconditionally > (without event mask). > > Signed-off-by: Vakul Garg > --- > v6->v7: Improved the commit message to contain the detailed reasoning. > (The same analysis was shared on the mail list.) Applied.