From: David Miller <davem@davemloft.net>
To: sd@queasysnail.net
Cc: netdev@vger.kernel.org, dsahern@gmail.com
Subject: Re: [PATCH net] net/ipv6: fix metrics leak
Date: Mon, 30 Jul 2018 09:46:37 -0700 (PDT) [thread overview]
Message-ID: <20180730.094637.1751168123955659634.davem@davemloft.net> (raw)
In-Reply-To: <e19b81fff08014ff9bf20412f41bb2cf460ae6ed.1532960405.git.sd@queasysnail.net>
From: Sabrina Dubroca <sd@queasysnail.net>
Date: Mon, 30 Jul 2018 16:23:10 +0200
> Since commit d4ead6b34b67 ("net/ipv6: move metrics from dst to
> rt6_info"), ipv6 metrics are shared and refcounted. rt6_set_from()
> assigns the rt->from pointer and increases the refcount on from's
> metrics. This reference is never released.
>
> Introduce the fib6_metrics_release() helper and use it to release the
> metrics.
>
> Fixes: d4ead6b34b67 ("net/ipv6: move metrics from dst to rt6_info")
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Looks good, applied, thanks.
prev parent reply other threads:[~2018-07-30 18:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 14:23 [PATCH net] net/ipv6: fix metrics leak Sabrina Dubroca
2018-07-30 16:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730.094637.1751168123955659634.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).