From: Dominique Martinet <asmadeus@codewreck.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
v9fs-developer@lists.sourceforge.net,
Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [PATCH PATCH net-next 10/18] 9p: fix whitespace issues
Date: Mon, 30 Jul 2018 05:54:45 +0200 [thread overview]
Message-ID: <20180730035445.GA820@nautica> (raw)
In-Reply-To: <20180724192918.31165-11-sthemmin@microsoft.com>
(removed tons of Cc to make v9fs-developer@ happy - please do include
linux-kernel@vger.kernel.org next time though, I only saw this patch by
chance snooping at netdev)
Stephen Hemminger wrote on Tue, Jul 24, 2018:
> Remove trailing whitespace and blank lines at EOF
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
LGTM, I'm not sure if someone would pick the whole series but as other
maintainers seem to have taken individual patches I've taken this one as
there's potential conflicts with what I have (planning to remove the
whole net/9p/util.c file)
> ---
> net/9p/client.c | 4 ++--
> net/9p/trans_virtio.c | 2 +-
> net/9p/util.c | 1 -
> 3 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/net/9p/client.c b/net/9p/client.c
> index 5c1343195292..ff02826e0407 100644
> --- a/net/9p/client.c
> +++ b/net/9p/client.c
> @@ -341,7 +341,7 @@ struct p9_req_t *p9_tag_lookup(struct p9_client *c, u16 tag)
> * buffer to read the data into */
> tag++;
>
> - if(tag >= c->max_tag)
> + if (tag >= c->max_tag)
> return NULL;
>
> row = tag / P9_ROW_MAXTAG;
> @@ -1576,7 +1576,7 @@ p9_client_read(struct p9_fid *fid, u64 offset, struct iov_iter *to, int *err)
> int count = iov_iter_count(to);
> int rsize, non_zc = 0;
> char *dataptr;
> -
> +
> rsize = fid->iounit;
> if (!rsize || rsize > clnt->msize-P9_IOHDRSZ)
> rsize = clnt->msize - P9_IOHDRSZ;
> diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c
> index 05006cbb3361..279b24488d79 100644
> --- a/net/9p/trans_virtio.c
> +++ b/net/9p/trans_virtio.c
> @@ -446,7 +446,7 @@ p9_virtio_zc_request(struct p9_client *client, struct p9_req_t *req,
> out += pack_sg_list_p(chan->sg, out, VIRTQUEUE_NUM,
> out_pages, out_nr_pages, offs, outlen);
> }
> -
> +
> /*
> * Take care of in data
> * For example TREAD have 11.
> diff --git a/net/9p/util.c b/net/9p/util.c
> index 59f278e64f58..55ad98277e85 100644
> --- a/net/9p/util.c
> +++ b/net/9p/util.c
> @@ -138,4 +138,3 @@ int p9_idpool_check(int id, struct p9_idpool *p)
> return idr_find(&p->pool, id) != NULL;
> }
> EXPORT_SYMBOL(p9_idpool_check);
> -
--
Dominique Martinet
next prev parent reply other threads:[~2018-07-30 5:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 19:29 [PATCH PATCH net-next 00/18] net whitespace cleanups Stephen Hemminger
[not found] ` <20180724192918.31165-1-sthemmin-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>
2018-07-24 19:29 ` [PATCH PATCH net-next 01/18] sched: fix trailing whitespace Stephen Hemminger
2018-07-24 19:29 ` [PATCH PATCH net-next 02/18] wimax: remove blank lines at EOF Stephen Hemminger
2018-07-24 19:29 ` [PATCH PATCH net-next 05/18] mpls: remove trailing whitepace Stephen Hemminger
2018-07-24 19:29 ` [PATCH PATCH net-next 06/18] xfrm: remove blank lines at EOF Stephen Hemminger
2018-07-24 19:29 ` [PATCH PATCH net-next 08/18] sctp: whitespace fixes Stephen Hemminger
2018-07-25 12:59 ` Neil Horman
2018-07-24 19:29 ` [PATCH PATCH net-next 10/18] 9p: fix whitespace issues Stephen Hemminger
2018-07-30 3:54 ` Dominique Martinet [this message]
2018-07-24 19:29 ` [PATCH PATCH net-next 12/18] ax25: remove blank line at EOF Stephen Hemminger
2018-07-24 19:29 ` [PATCH PATCH net-next 18/18] net: remove blank lines at end of file Stephen Hemminger
2018-07-24 19:29 ` [PATCH PATCH net-next 03/18] rds: remove trailing whitespace and blank lines Stephen Hemminger
2018-07-24 19:29 ` [PATCH PATCH net-next 04/18] llc: fix whitespace issues Stephen Hemminger
2018-07-24 19:29 ` [PATCH PATCH net-next 07/18] ceph: fix whitespace Stephen Hemminger
[not found] ` <20180724192918.31165-8-sthemmin-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>
2018-07-25 12:59 ` Ilya Dryomov
2018-07-24 19:29 ` [PATCH PATCH net-next 09/18] ila: remove blank lines at EOF Stephen Hemminger
2018-07-24 19:29 ` [PATCH PATCH net-next 11/18] atm: " Stephen Hemminger
2018-07-24 19:29 ` [PATCH PATCH net-next 13/18] x25: " Stephen Hemminger
2018-07-24 19:29 ` [PATCH PATCH net-next 14/18] decnet: whitespace fixes Stephen Hemminger
2018-07-24 19:29 ` [PATCH PATCH net-next 15/18] sunrpc: " Stephen Hemminger
2018-07-27 20:39 ` Anna Schumaker
2018-07-24 19:29 ` [PATCH PATCH net-next 16/18] bpfilter: remove trailing newline Stephen Hemminger
2018-07-24 19:29 ` [PATCH PATCH net-next 17/18] l2tp: " Stephen Hemminger
2018-07-24 21:11 ` [PATCH PATCH net-next 00/18] net whitespace cleanups David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730035445.GA820@nautica \
--to=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).