From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next v5 4/4] act_mirred: use TC_ACT_REINSERT when possible Date: Mon, 30 Jul 2018 14:42:54 +0200 Message-ID: <20180730124254.GG2058@nanopsycho> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Jamal Hadi Salim , Cong Wang , Daniel Borkmann , Marcelo Ricardo Leitner , Eyal Birger , "David S. Miller" To: Paolo Abeni Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:36409 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728812AbeG3OU0 (ORCPT ); Mon, 30 Jul 2018 10:20:26 -0400 Received: by mail-wm0-f65.google.com with SMTP id s14-v6so13670321wmc.1 for ; Mon, 30 Jul 2018 05:45:37 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Mon, Jul 30, 2018 at 02:30:45PM CEST, pabeni@redhat.com wrote: >When mirred is invoked from the ingress path, and it wants to redirect >the processed packet, it can now use the TC_ACT_REINSERT action, >filling the tcf_result accordingly, and avoiding a per packet >skb_clone(). > >Overall this gives a ~10% improvement in forwarding performance for the >TC S/W data path and TC S/W performances are now comparable to the >kernel openvswitch datapath. > >v1 -> v2: use ACT_MIRRED instead of ACT_REDIRECT >v2 -> v3: updated after action rename, fixed typo into the commit > message >v3 -> v4: updated again after action rename, added more comments to > the code (JiriP), skip the optimization if the control action > need to touch the tcf_result (Paolo) >v4 -> v5: fix sparse warning (kbuild bot) > >Signed-off-by: Paolo Abeni Acked-by: Jiri Pirko