From: Stephen Hemminger <stephen@networkplumber.org>
To: Wei Wang <weiwan@google.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Yuchung Cheng <ycheng@google.com>,
Neal Cardwell <ncardwell@google.com>,
Soheil Hassas Yeganeh <soheil@google.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next 2/4] tcp: add data bytes retransmitted stats
Date: Mon, 30 Jul 2018 15:14:14 -0700 [thread overview]
Message-ID: <20180730151414.4ce34375@xeon-e3> (raw)
In-Reply-To: <20180730215911.209895-3-tracywwnj@gmail.com>
On Mon, 30 Jul 2018 14:59:09 -0700
Wei Wang <weiwan@google.com> wrote:
> + stats = alloc_skb(9 * nla_total_size_64bit(sizeof(u64)) +
> 7 * nla_total_size(sizeof(u32)) +
> 3 * nla_total_size(sizeof(u8)), GFP_ATOMIC);
This is getting a bit awkward.
Maybe use the style used in other drivers that have a get_size function
like tun_get_size().
next prev parent reply other threads:[~2018-07-30 23:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 21:59 [PATCH net-next 0/4] tcp: add 4 new stats Wei Wang
2018-07-30 21:59 ` [PATCH net-next 1/4] tcp: add data bytes sent stats Wei Wang
2018-07-30 21:59 ` [PATCH net-next 2/4] tcp: add data bytes retransmitted stats Wei Wang
2018-07-30 21:59 ` [PATCH net-next 3/4] tcp: add dsack blocks received stats Wei Wang
2018-07-30 21:59 ` [PATCH net-next 4/4] tcp: add stat of data packet reordering events Wei Wang
2018-07-30 22:14 ` Stephen Hemminger [this message]
2018-07-30 22:51 ` [PATCH net-next 2/4] tcp: add data bytes retransmitted stats Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730151414.4ce34375@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
--cc=weiwan@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).