From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net-next 2/4] tcp: add data bytes retransmitted stats
Date: Mon, 30 Jul 2018 15:14:14 -0700
Message-ID: <20180730151414.4ce34375@xeon-e3>
References: <20180730215911.209895-1-tracywwnj@gmail.com>
        <20180730215911.209895-2-tracywwnj@gmail.com>
        <20180730215911.209895-3-tracywwnj@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org,
        Yuchung Cheng <ycheng@google.com>,
        Neal Cardwell <ncardwell@google.com>,
        Soheil Hassas Yeganeh <soheil@google.com>,
        Eric Dumazet <edumazet@google.com>
To: Wei Wang <weiwan@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f65.google.com ([209.85.160.65]:34355 "EHLO
        mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727010AbeG3XvU (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 30 Jul 2018 19:51:20 -0400
Received: by mail-pl0-f65.google.com with SMTP id f6-v6so6180498plo.1
        for <netdev@vger.kernel.org>; Mon, 30 Jul 2018 15:14:17 -0700 (PDT)
In-Reply-To: <20180730215911.209895-3-tracywwnj@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, 30 Jul 2018 14:59:09 -0700
Wei Wang <weiwan@google.com> wrote:

> +	stats = alloc_skb(9 * nla_total_size_64bit(sizeof(u64)) +
>  			  7 * nla_total_size(sizeof(u32)) +
>  			  3 * nla_total_size(sizeof(u8)), GFP_ATOMIC);

This is getting a bit awkward.
Maybe use the style used in other drivers that have a get_size function
like tun_get_size().