From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT. Date: Mon, 30 Jul 2018 18:49:23 +0200 Message-ID: <20180730164923.GD10626@nanopsycho> References: <695eaa79e2c02c64f0daacd38c35c63bbdfee60f.1532934532.git.pabeni@redhat.com> <20180730124013.GF2058@nanopsycho> <20180730.093100.1043667653536689097.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: pabeni@redhat.com, netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, daniel@iogearbox.net, marcelo.leitner@gmail.com, eyal.birger@gmail.com To: David Miller Return-path: Received: from mail-wr1-f68.google.com ([209.85.221.68]:38869 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726668AbeG3S15 (ORCPT ); Mon, 30 Jul 2018 14:27:57 -0400 Received: by mail-wr1-f68.google.com with SMTP id v14-v6so13656026wro.5 for ; Mon, 30 Jul 2018 09:52:05 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180730.093100.1043667653536689097.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: Mon, Jul 30, 2018 at 06:31:00PM CEST, davem@davemloft.net wrote: >From: Jiri Pirko >Date: Mon, 30 Jul 2018 14:40:13 +0200 > >> Oh, another nitpick: The changelog should go under "---" line. That way, >> the maintainer does not have to deal with it during apply (git apply >> will cut it out). > >I actually like the changelog to be _IN_ the commit message. > >It's useful information that helps someone investigating history >in the tree later. > >Please do not tell people to pull changelogs out of the commit >message, thank you. I've been telling them to do the exact >opposite. Oups. Interesting. So the changelog stays in the commit message, right? I noticed that in the past but thought it was an accident. Sorry about that. I owe you just another beer :)