From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesper Dangaard Brouer <brouer@redhat.com>
Subject: Re: [net-next 10/13] net/mlx5e: Add support for XDP_REDIRECT in
 device-out side
Date: Mon, 30 Jul 2018 18:20:25 +0200
Message-ID: <20180730182025.602089a9@redhat.com>
References: <20180726225647.11926-1-saeedm@mellanox.com>
        <20180726225647.11926-11-saeedm@mellanox.com>
        <20180730141021.78b8260f@redhat.com>
        <20180730150637.0336d65b@redhat.com>
        <66f0a6c6-eb81-b348-2e1a-1fb8c98f73d7@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Saeed Mahameed <saeedm@mellanox.com>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        Eugenia Emantayev <eugenia@mellanox.com>, brouer@redhat.com,
        Toke =?UTF-8?B?SMO4aWxhbmQt?= =?UTF-8?B?SsO4cmdlbnNlbg==?=
        <toke@toke.dk>
To: Tariq Toukan <tariqt@mellanox.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59656 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1731395AbeG3R4P (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 30 Jul 2018 13:56:15 -0400
In-Reply-To: <66f0a6c6-eb81-b348-2e1a-1fb8c98f73d7@mellanox.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, 30 Jul 2018 16:09:47 +0300
Tariq Toukan <tariqt@mellanox.com> wrote:

> On 30/07/2018 4:06 PM, Jesper Dangaard Brouer wrote:
> > 
> > On Mon, 30 Jul 2018 14:10:21 +0200 Jesper Dangaard Brouer <brouer@redhat.com> wrote:
> >   
> >> On Thu, 26 Jul 2018 15:56:44 -0700 Saeed Mahameed <saeedm@mellanox.com> wrote:
> >>  
> >>> +int mlx5e_xdp_xmit(struct net_device *dev, int n, struct xdp_frame **frames,
> >>> +		   u32 flags)
> >>> +{  
> > [...]  
> >>> +		xdpi.dma_addr = dma_map_single(sq->pdev, xdpf->data, xdpf->len,
> >>> +					       DMA_TO_DEVICE);
> >>> +		if (unlikely(dma_mapping_error(sq->pdev, xdpi.dma_addr))) {
> >>> +			drops++;  
> >>
> >> I think you are missing a xdp_return_frame_rx_napi(xdpf) here.  
> > 
> > I see it already got applied... I'll send a fixup later...
> >   
> 
> Yes it is applied, I can do it myself. Just let me know what you prefer.

I can take care of this.  I already have a patch ready.  And I'm eager
to test these patches and compare the performance to the results Toke
and I got for the article based on your earlier patches[1].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/hawk/net-next-xdp.git/log/?h=xdp_paper01

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer