From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, linville@tuxdriver.com,
davem@davemloft.net, vivien.didelot@savoirfairelinux.com
Subject: Re: [PATCH ethtool] ethtool: Add support for WAKE_FILTER
Date: Tue, 31 Jul 2018 00:55:42 +0200 [thread overview]
Message-ID: <20180730225542.GC10559@lunn.ch> (raw)
In-Reply-To: <ef6c3945-531a-b5d3-efa0-db3440d91d7b@gmail.com>
> The thing is that I need this now, but when Michal's work on ethtool
> being migrated to netlink settles, we should have have any issues adding
> a proper storage area for specifying filters anymore. The issue here is
> of course that the size and layout of ethtool_wolinfo is largely fixed
> and set in stone, and therefore inflexible.
The version in uapi/linux/ethtool.h is fixed. But i think in order to
implement this properly, you are going to have to change the internal
structure passed to ethtool_ops->set_wol/get_wol, with the filter
separated out from the sopass. ethtool_set_wol()/ethtool_get_wol()
would then need to know how to correctly unpack the structure passed
in the ioctl, where as the netlink socket code and just put attributes
into structure members.
Andrew
next prev parent reply other threads:[~2018-07-31 0:32 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 15:36 [PATCH net-next 0/7] net: Support Wake-on-LAN using filters Florian Fainelli
2018-07-17 15:36 ` [PATCH ethtool] ethtool: Add support for WAKE_FILTER Florian Fainelli
2018-07-30 22:26 ` Florian Fainelli
2018-07-30 22:30 ` Andrew Lunn
2018-07-30 22:39 ` Florian Fainelli
2018-07-30 22:55 ` Andrew Lunn [this message]
2018-07-30 23:01 ` Andrew Lunn
2018-08-01 16:32 ` David Miller
2018-08-03 17:57 ` Florian Fainelli
2018-08-03 19:07 ` David Miller
2018-08-03 19:58 ` Florian Fainelli
2018-08-03 20:18 ` David Miller
2018-07-17 15:36 ` [PATCH net-next 1/7] net: dsa: bcm_sf2: Allow targeting CPU ports for CFP rules Florian Fainelli
2018-07-18 0:56 ` David Miller
2018-07-17 15:36 ` [PATCH net-next 2/7] net: dsa: bcm_sf2: Disable learning while in WoL Florian Fainelli
2018-07-17 15:54 ` Andrew Lunn
2018-07-17 16:06 ` Florian Fainelli
2018-07-17 15:36 ` [PATCH net-next 3/7] net: systemport: Do not re-configure upon WoL interrupt Florian Fainelli
2018-07-17 15:36 ` [PATCH net-next 4/7] net: systemport: Create helper to set MPD Florian Fainelli
2018-07-17 15:36 ` [PATCH net-next 5/7] ethtool: Add WAKE_FILTER bitmask Florian Fainelli
2018-07-17 15:36 ` [PATCH net-next 6/7] net: systemport: Add support for WAKE_FILTER Florian Fainelli
2018-07-17 16:14 ` Andrew Lunn
2018-07-17 16:26 ` Florian Fainelli
2018-07-17 16:49 ` Andrew Lunn
2018-07-17 16:57 ` Florian Fainelli
2018-07-17 17:06 ` Andrew Lunn
2018-07-18 9:15 ` Florian Fainelli
2018-07-19 22:25 ` Andrew Lunn
2018-07-20 9:34 ` Florian Fainelli
2018-07-17 15:36 ` [PATCH net-next 7/7] net: dsa: bcm_sf2: Support WAKE_FILTER Florian Fainelli
2018-07-17 15:47 ` [PATCH net-next 0/7] net: Support Wake-on-LAN using filters Andrew Lunn
2018-07-17 16:06 ` Florian Fainelli
2018-07-17 16:21 ` Andrew Lunn
2018-07-17 16:28 ` Florian Fainelli
2018-07-17 16:51 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730225542.GC10559@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).