From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH ethtool] ethtool: Add support for WAKE_FILTER Date: Tue, 31 Jul 2018 00:55:42 +0200 Message-ID: <20180730225542.GC10559@lunn.ch> References: <20180717153645.7500-1-f.fainelli@gmail.com> <20180717153645.7500-2-f.fainelli@gmail.com> <47f52797-1540-5eeb-5ea8-3c0984fdfb11@gmail.com> <20180730223045.GB10559@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, linville@tuxdriver.com, davem@davemloft.net, vivien.didelot@savoirfairelinux.com To: Florian Fainelli Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:50972 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727063AbeGaAc5 (ORCPT ); Mon, 30 Jul 2018 20:32:57 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: > The thing is that I need this now, but when Michal's work on ethtool > being migrated to netlink settles, we should have have any issues adding > a proper storage area for specifying filters anymore. The issue here is > of course that the size and layout of ethtool_wolinfo is largely fixed > and set in stone, and therefore inflexible. The version in uapi/linux/ethtool.h is fixed. But i think in order to implement this properly, you are going to have to change the internal structure passed to ethtool_ops->set_wol/get_wol, with the filter separated out from the sopass. ethtool_set_wol()/ethtool_get_wol() would then need to know how to correctly unpack the structure passed in the ioctl, where as the netlink socket code and just put attributes into structure members. Andrew