From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH ethtool] ethtool: Add support for WAKE_FILTER
Date: Tue, 31 Jul 2018 01:01:01 +0200
Message-ID: <20180730230101.GD10559@lunn.ch>
References: <20180717153645.7500-1-f.fainelli@gmail.com>
 <20180717153645.7500-2-f.fainelli@gmail.com>
 <47f52797-1540-5eeb-5ea8-3c0984fdfb11@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, linville@tuxdriver.com,
        davem@davemloft.net, vivien.didelot@savoirfairelinux.com
To: Florian Fainelli <f.fainelli@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:50981 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1732004AbeGaAiQ (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 30 Jul 2018 20:38:16 -0400
Content-Disposition: inline
In-Reply-To: <47f52797-1540-5eeb-5ea8-3c0984fdfb11@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> One usability issue with this approach is that one cannot specify
> wake-on-LAN using WAKE_MAGICSECURE *and* WAKE_FILTER at the same time,
> since it uses the same location in the ioctl() structure that is being
> passed. Do you see this as a problem?

Hi Florian

I think you missed adding a check for this. ethtool_set_wol() should
check if both WAKE_FILTER and WAKE_MAGICSECURE are set and return
EINVAL.

	Andrew