From: David Miller <davem@davemloft.net>
To: tariqt@mellanox.com
Cc: brouer@redhat.com, saeedm@mellanox.com, netdev@vger.kernel.org,
eugenia@mellanox.com
Subject: Re: [net-next PATCH] mlx5: handle DMA mapping error case for XDP redirect
Date: Tue, 31 Jul 2018 09:47:00 -0700 (PDT) [thread overview]
Message-ID: <20180731.094700.2256113713700645687.davem@davemloft.net> (raw)
In-Reply-To: <112892c8-c915-6ae0-f76b-23285fb73efc@mellanox.com>
From: Tariq Toukan <tariqt@mellanox.com>
Date: Tue, 31 Jul 2018 09:35:37 +0300
> On 30/07/2018 8:49 PM, Jesper Dangaard Brouer wrote:
>> Commit 58b99ee3e3eb ("net/mlx5e: Add support for XDP_REDIRECT in
>> device-out side")
>> forgot to return/free the xdp_frame in case the DMA mapping failed,
>> correct this.
>> Also DMA unmap the frame in case mlx5e_xmit_xdp_frame() fails.
>> Fixes: 58b99ee3e3eb ("net/mlx5e: Add support for XDP_REDIRECT in
>> device-out side")
>> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
...
> Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Applied.
next prev parent reply other threads:[~2018-07-31 18:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 22:56 [pull request][net-next 00/13] Mellanox, mlx5e updates 2018-07-26 (XDP redirect) Saeed Mahameed
2018-07-26 22:56 ` [net-next 01/13] net/mlx5e: Replace call to MPWQE free with dealloc in interface down flow Saeed Mahameed
2018-07-26 22:56 ` [net-next 02/13] net/mlx5e: Do not recycle RX pages " Saeed Mahameed
2018-07-26 22:56 ` [net-next 03/13] net/mlx5e: Gather all XDP pre-requisite checks in a single function Saeed Mahameed
2018-07-26 22:56 ` [net-next 04/13] net/mlx5e: Restrict the combination of large MTU and XDP Saeed Mahameed
2018-07-26 22:56 ` [net-next 05/13] net/mlx5e: Move XDP related code into new XDP files Saeed Mahameed
2018-07-26 22:56 ` [net-next 06/13] net/mlx5e: Add counter for XDP redirect in RX Saeed Mahameed
2018-07-26 22:56 ` [net-next 07/13] net/mlx5e: Make XDP xmit functions more generic Saeed Mahameed
2018-07-26 22:56 ` [net-next 08/13] net/mlx5e: Refactor XDP counters Saeed Mahameed
2018-07-26 22:56 ` [net-next 09/13] net/mlx5e: Re-order fields of struct mlx5e_xdpsq Saeed Mahameed
2018-07-26 22:56 ` [net-next 10/13] net/mlx5e: Add support for XDP_REDIRECT in device-out side Saeed Mahameed
2018-07-30 12:10 ` Jesper Dangaard Brouer
2018-07-30 13:05 ` Tariq Toukan
2018-07-30 13:06 ` Jesper Dangaard Brouer
2018-07-30 13:09 ` Tariq Toukan
2018-07-30 16:20 ` Jesper Dangaard Brouer
2018-07-30 17:49 ` [net-next PATCH] mlx5: handle DMA mapping error case for XDP redirect Jesper Dangaard Brouer
2018-07-31 6:35 ` Tariq Toukan
2018-07-31 16:47 ` David Miller [this message]
2018-07-26 22:56 ` [net-next 11/13] net/mlx5e: RX, Prefetch the xdp_frame data area Saeed Mahameed
2018-07-26 22:56 ` [net-next 12/13] net/mlx5e: TX, Move DB fields in TXQ-SQ struct Saeed Mahameed
2018-07-26 22:56 ` [net-next 13/13] net/mlx5e: TX, Use function to access sq_dma object in fifo Saeed Mahameed
2018-07-27 4:33 ` [pull request][net-next 00/13] Mellanox, mlx5e updates 2018-07-26 (XDP redirect) David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731.094700.2256113713700645687.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brouer@redhat.com \
--cc=eugenia@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).