From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: remove bogus RCU annotations on socket.wq
Date: Mon, 30 Jul 2018 17:51:24 -0700 [thread overview]
Message-ID: <20180731005124.GH24813@linux.vnet.ibm.com> (raw)
In-Reply-To: <bd0e18ee-c3be-fef2-b2b8-3a2ad576f765@gmail.com>
On Mon, Jul 30, 2018 at 03:23:06PM -0700, Eric Dumazet wrote:
>
>
> On 07/30/2018 12:45 AM, Christoph Hellwig wrote:
> > We never use RCU protection for it, just a lot of cargo-cult
> > rcu_deference_protects calls.
> >
> > Note that we do keep the kfree_rcu call for it, as the references through
> > struct sock are RCU protected and thus might require a grace period before
> > freeing.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
next prev parent reply other threads:[~2018-07-31 0:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 7:45 socket poll related cleanups v2 Christoph Hellwig
2018-07-30 7:45 ` [PATCH] net: remove bogus RCU annotations on socket.wq Christoph Hellwig
2018-07-30 22:23 ` Eric Dumazet
2018-07-31 0:51 ` Paul E. McKenney [this message]
2018-07-31 19:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731005124.GH24813@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).