From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Paul E. McKenney" Subject: Re: [PATCH] net: remove bogus RCU annotations on socket.wq Date: Mon, 30 Jul 2018 17:51:24 -0700 Message-ID: <20180731005124.GH24813@linux.vnet.ibm.com> References: <20180730074507.17037-1-hch@lst.de> <20180730074507.17037-2-hch@lst.de> Reply-To: paulmck@linux.vnet.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Eric Dumazet , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Eric Dumazet Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, Jul 30, 2018 at 03:23:06PM -0700, Eric Dumazet wrote: > > > On 07/30/2018 12:45 AM, Christoph Hellwig wrote: > > We never use RCU protection for it, just a lot of cargo-cult > > rcu_deference_protects calls. > > > > Note that we do keep the kfree_rcu call for it, as the references through > > struct sock are RCU protected and thus might require a grace period before > > freeing. > > > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Eric Dumazet Acked-by: Paul E. McKenney