From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Schulz Subject: Re: [PATCH net-next] net: phy: mscc: the extended page access register is 16 bits Date: Tue, 31 Jul 2018 08:43:33 +0200 Message-ID: <20180731064333.fkkbgnat3gdn3fhs@qschulz> References: <20180730125313.3405-1-quentin.schulz@bootlin.com> <4dd7d451-a1e3-cab8-dc5a-6666c5d29089@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="64r6gjhm5kjlvbil" Cc: andrew@lunn.ch, davem@davemloft.net, netdev@vger.kernel.org, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com To: Florian Fainelli Return-path: Content-Disposition: inline In-Reply-To: <4dd7d451-a1e3-cab8-dc5a-6666c5d29089@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org --64r6gjhm5kjlvbil Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Florian, On Mon, Jul 30, 2018 at 09:53:31AM -0700, Florian Fainelli wrote: > On 07/30/2018 05:53 AM, Quentin Schulz wrote: > > The Extended Page Access is a 16-bit register, so change the page > > parameter of vsc85xx_phy_page_set to a u16. > >=20 > > Signed-off-by: Quentin Schulz >=20 > Since you targeted net-next for this patch, I am assuming this is not > yet a problem, but would soon be one with the changes you plan on > introducing? >=20 Yes indeed. When I get the quad-port PHY things to go as planned, then I'll need sometimes to change to a page that is above the size of a u16. For now, all the pages are accessed with a number that is lower than the size of a u16, so it isn't a problem. Quentin --64r6gjhm5kjlvbil Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEXeEYjDsJh38OoyMzhLiadT7g8aMFAltgBRQACgkQhLiadT7g 8aNk4A//djVm3SUcdyWMY22zTkiGXBdNVzbvE464sZFNEXISb/NpTQzxoujYX7FR F0pXrmBmm8mZaNLZBYijnl/Vk8PnwGjadE2YnL3b04WFFCa/4jrmHE6eaznrk1qo yGKcM5tvGH9ldOMnp/lcAP6U8iYUZXDaILFjCfdHuNyNWWr9fErMqoK+bBHS3/Yd k1AB0/Z3Xu29xL4/FDvFQEHq0JtfmQdsniIcTj4aNDelMfO2CL7spMWndlNlyZxg iplPzxo8rDHaeEznm7EBDqizIJ0YlDWRdAye4QGylHh23TW9IOV05apaGiUXZUZm u8I5AJVi3Qw4mUnUMcABq3oeZktM8vcFLT87YiCvkzQSp/H0LsHQCHxcfaKzI6Go 7SKe1Cs8QqsirXiYEJdA6Pm7Kg7Y3YMzGRgqRZpqLYYPw5HlBODh5m8Pleoeb8Ls Mx8DFb7F/KuRj84iUw4hfyJn9FUMzq/p8yv9BX7yqXMG7iDqMU1AhZgpqsxn9q2t rYuSkztsxavhWraPQL67sfqA/CJ/QpQZyuH6WHzsPx+MwmiFqzLuUgSghC1rGVxC PICe7d8QenN7QDgBTmWG+ydKx0HNOoSCCT3MfZIHbpah55d+CJ1N3q9ibionbUAk 7ooV3gqQsjYbFk6kUGOqSEuP5RL2Le1AMWdWt3zYRfFNi/cQjuI= =HUlx -----END PGP SIGNATURE----- --64r6gjhm5kjlvbil--