* [PATCH] mwifiex: Fix skipped vendor specific IEs
@ 2018-07-24 11:47 roman.stratiienko-hExfYMNmJl/Cnp4W7fqMDg
2018-07-31 6:58 ` Kalle Valo
2018-07-31 7:13 ` Kalle Valo
0 siblings, 2 replies; 6+ messages in thread
From: roman.stratiienko-hExfYMNmJl/Cnp4W7fqMDg @ 2018-07-24 11:47 UTC (permalink / raw)
To: akarwar-eYqpPyKDWXRBDgjK7y7TUQ
Cc: nishants-eYqpPyKDWXRBDgjK7y7TUQ, kvalo-sgV2jX0FEOL9JmXXK+q4OQ,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8,
Roman Stratiienko
From: Roman Stratiienko <roman.stratiienko-hExfYMNmJl/Cnp4W7fqMDg@public.gmane.org>
Mwifiex firmware inserts only Microsoft information element
Allow other vendor specific IEs to pass from userspace
Signed-off-by: Roman Stratiienko <roman.stratiienko-hExfYMNmJl/Cnp4W7fqMDg@public.gmane.org>
---
drivers/net/wireless/marvell/mwifiex/ie.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/ie.c b/drivers/net/wireless/marvell/mwifiex/ie.c
index b10baac..75cbd60 100644
--- a/drivers/net/wireless/marvell/mwifiex/ie.c
+++ b/drivers/net/wireless/marvell/mwifiex/ie.c
@@ -355,8 +355,14 @@ static int mwifiex_uap_parse_tail_ies(struct mwifiex_private *priv,
case WLAN_EID_HT_OPERATION:
case WLAN_EID_VHT_CAPABILITY:
case WLAN_EID_VHT_OPERATION:
- case WLAN_EID_VENDOR_SPECIFIC:
break;
+ case WLAN_EID_VENDOR_SPECIFIC:
+ /* Skip only Microsoft WMM IE */
+ if (cfg80211_find_vendor_ie(WLAN_OUI_MICROSOFT,
+ WLAN_OUI_TYPE_MICROSOFT_WMM,
+ (const u8 *)hdr,
+ hdr->len + sizeof(struct ieee_types_header)))
+ break;
default:
memcpy(gen_ie->ie_buffer + ie_len, hdr,
hdr->len + sizeof(struct ieee_types_header));
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mwifiex: Fix skipped vendor specific IEs
2018-07-24 11:47 [PATCH] mwifiex: Fix skipped vendor specific IEs roman.stratiienko-hExfYMNmJl/Cnp4W7fqMDg
@ 2018-07-31 6:58 ` Kalle Valo
2018-07-31 7:13 ` Kalle Valo
1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2018-07-31 6:58 UTC (permalink / raw)
To: roman.stratiienko
Cc: akarwar, nishants, linux-wireless, netdev, linux-kernel,
sergei.shtylyov, Roman Stratiienko
roman.stratiienko@globallogic.com wrote:
> From: Roman Stratiienko <roman.stratiienko@globallogic.com>
>
> Mwifiex firmware inserts only Microsoft information element
> Allow other vendor specific IEs to pass from userspace
>
> Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
When you submit a new version fo a patch please always add a version number to
the title and include a changelog:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing
But this is for the future, no need to resend this patch.
--
https://patchwork.kernel.org/patch/10541923/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mwifiex: Fix skipped vendor specific IEs
2018-07-24 11:47 [PATCH] mwifiex: Fix skipped vendor specific IEs roman.stratiienko-hExfYMNmJl/Cnp4W7fqMDg
2018-07-31 6:58 ` Kalle Valo
@ 2018-07-31 7:13 ` Kalle Valo
1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2018-07-31 7:13 UTC (permalink / raw)
To: roman.stratiienko
Cc: akarwar, nishants, linux-wireless, netdev, linux-kernel,
sergei.shtylyov, Roman Stratiienko
roman.stratiienko@globallogic.com wrote:
> From: Roman Stratiienko <roman.stratiienko@globallogic.com>
>
> Mwifiex firmware inserts only Microsoft information element
> Allow other vendor specific IEs to pass from userspace
>
> Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
Patch applied to wireless-drivers-next.git, thanks.
bfc83ea196ad mwifiex: Fix skipped vendor specific IEs
--
https://patchwork.kernel.org/patch/10541923/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] mwifiex: Fix skipped vendor specific IEs
@ 2018-07-23 13:31 roman.stratiienko
2018-07-24 9:07 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: roman.stratiienko @ 2018-07-23 13:31 UTC (permalink / raw)
To: akarwar
Cc: nishants, kvalo, linux-wireless, netdev, linux-kernel,
Roman Stratiienko
From: Roman Stratiienko <roman.stratiienko@globallogic.com>
Only microsoft specific IE is added by FW
Let other IEs to pass from userspace
Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
---
drivers/net/wireless/marvell/mwifiex/ie.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/ie.c b/drivers/net/wireless/marvell/mwifiex/ie.c
index c488c30..c58b345 100644
--- a/drivers/net/wireless/marvell/mwifiex/ie.c
+++ b/drivers/net/wireless/marvell/mwifiex/ie.c
@@ -353,8 +353,16 @@ static int mwifiex_uap_parse_tail_ies(struct mwifiex_private *priv,
case WLAN_EID_HT_OPERATION:
case WLAN_EID_VHT_CAPABILITY:
case WLAN_EID_VHT_OPERATION:
- case WLAN_EID_VENDOR_SPECIFIC:
break;
+ case WLAN_EID_VENDOR_SPECIFIC:
+ /* Skip only Microsoft IE that added by FW
+ * Let other vendor specific IE to pass
+ */
+ if (cfg80211_find_vendor_ie(WLAN_OUI_MICROSOFT,
+ WLAN_OUI_TYPE_MICROSOFT_WMM,
+ (const u8 *)hdr,
+ hdr->len + sizeof(struct ieee_types_header)))
+ break;
default:
memcpy(gen_ie->ie_buffer + ie_len, hdr,
hdr->len + sizeof(struct ieee_types_header));
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mwifiex: Fix skipped vendor specific IEs
2018-07-23 13:31 roman.stratiienko
@ 2018-07-24 9:07 ` Sergei Shtylyov
0 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2018-07-24 9:07 UTC (permalink / raw)
To: roman.stratiienko, akarwar
Cc: nishants, kvalo, linux-wireless, netdev, linux-kernel
Hello!
On 7/23/2018 4:31 PM, roman.stratiienko@globallogic.com wrote:
> From: Roman Stratiienko <roman.stratiienko@globallogic.com>
>
> Only microsoft specific IE is added by FW
> Let other IEs to pass from userspace
"To" not needed here.
>
> Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
> ---
> drivers/net/wireless/marvell/mwifiex/ie.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/ie.c b/drivers/net/wireless/marvell/mwifiex/ie.c
> index c488c30..c58b345 100644
> --- a/drivers/net/wireless/marvell/mwifiex/ie.c
> +++ b/drivers/net/wireless/marvell/mwifiex/ie.c
> @@ -353,8 +353,16 @@ static int mwifiex_uap_parse_tail_ies(struct mwifiex_private *priv,
> case WLAN_EID_HT_OPERATION:
> case WLAN_EID_VHT_CAPABILITY:
> case WLAN_EID_VHT_OPERATION:
> - case WLAN_EID_VENDOR_SPECIFIC:
> break;
> + case WLAN_EID_VENDOR_SPECIFIC:
> + /* Skip only Microsoft IE that added by FW
^^^^
That's?
> + * Let other vendor specific IE to pass
"To" not needed here as well...
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] mwifiex: Fix skipped vendor specific IEs
@ 2018-07-13 17:37 roman.stratiienko-hExfYMNmJl/Cnp4W7fqMDg
0 siblings, 0 replies; 6+ messages in thread
From: roman.stratiienko-hExfYMNmJl/Cnp4W7fqMDg @ 2018-07-13 17:37 UTC (permalink / raw)
To: akarwar-eYqpPyKDWXRBDgjK7y7TUQ
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Roman Stratiienko
From: Roman Stratiienko <roman.stratiienko-hExfYMNmJl/Cnp4W7fqMDg@public.gmane.org>
Only microsoft specific IE is added by FW
Let other IEs to pass from userspace
Signed-off-by: Roman Stratiienko <roman.stratiienko-hExfYMNmJl/Cnp4W7fqMDg@public.gmane.org>
---
drivers/net/wireless/marvell/mwifiex/ie.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/ie.c b/drivers/net/wireless/marvell/mwifiex/ie.c
index c488c30..c58b345 100644
--- a/drivers/net/wireless/marvell/mwifiex/ie.c
+++ b/drivers/net/wireless/marvell/mwifiex/ie.c
@@ -353,8 +353,16 @@ static int mwifiex_uap_parse_tail_ies(struct mwifiex_private *priv,
case WLAN_EID_HT_OPERATION:
case WLAN_EID_VHT_CAPABILITY:
case WLAN_EID_VHT_OPERATION:
- case WLAN_EID_VENDOR_SPECIFIC:
break;
+ case WLAN_EID_VENDOR_SPECIFIC:
+ /* Skip only Microsoft IE that added by FW
+ * Let other vendor specific IE to pass
+ */
+ if (cfg80211_find_vendor_ie(WLAN_OUI_MICROSOFT,
+ WLAN_OUI_TYPE_MICROSOFT_WMM,
+ (const u8 *)hdr,
+ hdr->len + sizeof(struct ieee_types_header)))
+ break;
default:
memcpy(gen_ie->ie_buffer + ie_len, hdr,
hdr->len + sizeof(struct ieee_types_header));
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-31 7:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-24 11:47 [PATCH] mwifiex: Fix skipped vendor specific IEs roman.stratiienko-hExfYMNmJl/Cnp4W7fqMDg
2018-07-31 6:58 ` Kalle Valo
2018-07-31 7:13 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2018-07-23 13:31 roman.stratiienko
2018-07-24 9:07 ` Sergei Shtylyov
2018-07-13 17:37 roman.stratiienko-hExfYMNmJl/Cnp4W7fqMDg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).