From: Kalle Valo <kvalo@codeaurora.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: <j@w1.fi>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-wireless@vger.kernel.org>,
<davem@davemloft.net>, YueHaibing <yuehaibing@huawei.com>
Subject: Re: [PATCH] hostap: hide unused procfs helpers
Date: Tue, 31 Jul 2018 07:21:52 +0000 (UTC) [thread overview]
Message-ID: <20180731072152.D79D860376@smtp.codeaurora.org> (raw)
In-Reply-To: <20180713070317.6724-1-yuehaibing@huawei.com>
YueHaibing <yuehaibing@huawei.com> wrote:
> When CONFIG_PROC_FS isn't set, gcc warning this:
>
> drivers/net/wireless/intersil/hostap/hostap_hw.c:2901:12: warning: ‘prism2_registers_proc_show’ defined but not used [-Wunused-function]
> static int prism2_registers_proc_show(struct seq_file *m, void *v)
>
> drivers/net/wireless/intersil/hostap/hostap_proc.c:16:12: warning: ‘prism2_debug_proc_show’ defined but not used [-Wunused-function]
> static int prism2_debug_proc_show(struct seq_file *m, void *v)
> ^
> drivers/net/wireless/intersil/hostap/hostap_proc.c:49:12: warning: ‘prism2_stats_proc_show’ defined but not used [-Wunused-function]
> static int prism2_stats_proc_show(struct seq_file *m, void *v)
> ^
> drivers/net/wireless/intersil/hostap/hostap_proc.c:177:12: warning: ‘prism2_crypt_proc_show’ defined but not used [-Wunused-function]
> static int prism2_crypt_proc_show(struct seq_file *m, void *v)
> ^
>
> fix this by adding #ifdef around them.
> hfa384x_read_reg is only used by prism2_registers_proc_show,so move it
> into #ifdef.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
6ade689711ee hostap: hide unused procfs helpers
--
https://patchwork.kernel.org/patch/10522651/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2018-07-31 7:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 7:03 [PATCH] hostap: hide unused procfs helpers YueHaibing
[not found] ` <20180713070317.6724-1-yuehaibing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2018-07-13 7:26 ` Arend van Spriel
2018-07-13 9:37 ` YueHaibing
2018-07-13 16:43 ` Randy Dunlap
2018-07-27 9:25 ` Kalle Valo
2018-07-27 10:03 ` YueHaibing
2018-07-27 15:46 ` Randy Dunlap
2018-07-31 7:21 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731072152.D79D860376@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=j@w1.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).