From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] rtl818x: Replace mdelay() with msleep() in rtl8225se_rf_init Date: Tue, 31 Jul 2018 07:27:03 +0000 (UTC) Message-ID: <20180731072703.6141960708@smtp.codeaurora.org> References: <20180727085045.3949-1-baijiaju1990@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jia-Ju Bai To: Jia-Ju Bai Return-path: In-Reply-To: <20180727085045.3949-1-baijiaju1990-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Jia-Ju Bai wrote: > rtl8225se_rf_init() is never called in atomic context. > It calls mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep(). > This patch only replaces the mdelay() that has >20ms time to wait. > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai Patch applied to wireless-drivers-next.git, thanks. 622e938240db rtl818x: Replace mdelay() with msleep() in rtl8225se_rf_init -- https://patchwork.kernel.org/patch/10546749/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches