From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] net: wireless: ath6kl: Replace GFP_ATOMIC with GFP_KERNEL in ath6kl_bmi_init() Date: Tue, 31 Jul 2018 07:50:27 +0000 (UTC) Message-ID: <20180731075027.1FA2D6071C@smtp.codeaurora.org> References: <20180727084318.3345-1-baijiaju1990@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: kvalo@qca.qualcomm.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai To: Jia-Ju Bai Return-path: In-Reply-To: <20180727084318.3345-1-baijiaju1990@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Jia-Ju Bai wrote: > ath6kl_bmi_init() is never called in atomic context. > It calls kzalloc() with GFP_ATOMIC, which is not necessary. > GFP_ATOMIC can be replaced with GFP_KERNEL. > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. bfc55fe65987 ath6kl: replace GFP_ATOMIC with GFP_KERNEL in ath6kl_bmi_init() -- https://patchwork.kernel.org/patch/10546741/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches