From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v1 3/3] net: WireGuard secure network tunnel
Date: Tue, 31 Jul 2018 13:27:01 -0700
Message-ID: <20180731132701.522b55e2@xeon-e3>
References: <20180731191102.2434-1-Jason@zx2c4.com>
        <20180731191102.2434-4-Jason@zx2c4.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        davem@davemloft.net, Greg KH <gregkh@linuxfoundation.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f193.google.com ([209.85.215.193]:36619 "EHLO
        mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727346AbeGaWJI (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 31 Jul 2018 18:09:08 -0400
Received: by mail-pg1-f193.google.com with SMTP id s7-v6so9633461pgv.3
        for <netdev@vger.kernel.org>; Tue, 31 Jul 2018 13:27:05 -0700 (PDT)
In-Reply-To: <20180731191102.2434-4-Jason@zx2c4.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, 31 Jul 2018 21:11:02 +0200
"Jason A. Donenfeld" <Jason@zx2c4.com> wrote:

> +#define push(stack, p, len) ({ \
> +	if (rcu_access_pointer(p)) { \
> +		BUG_ON(len >= 128); \
> +		stack[len++] = rcu_dereference_protected(p, lockdep_is_held(lock)); \
> +	} \
> +	true; \
> +})
> +static void free_root_node(struct allowedips_node __rcu *top, struct mutex *lock)
> +{
> +	struct allowedips_node *stack[128], *node;
> +	unsigned int len;
> +
> +	for (len = 0, push(stack, top, len); len > 0 && (node = stack[--len]) && push(stack, node->bit[0], len) && push(stack, node->bit[1], len);)
> +		call_rcu_bh(&node->rcu, node_free_rcu);
> +}

This looks like you are doing traversal to free a tree.  The stack is there so that you do the rcu callbacks
in the proper order. Won't this create an lot of RCU work at once?