From: David Miller <davem@davemloft.net>
To: jcline@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jpoimboe@redhat.com
Subject: Re: [PATCH] netlink: Fix spectre v1 gadget in netlink_create()
Date: Wed, 01 Aug 2018 09:51:35 -0700 (PDT) [thread overview]
Message-ID: <20180801.095135.79911181296177212.davem@davemloft.net> (raw)
In-Reply-To: <20180731211316.12971-1-jcline@redhat.com>
From: Jeremy Cline <jcline@redhat.com>
Date: Tue, 31 Jul 2018 21:13:16 +0000
> 'protocol' is a user-controlled value, so sanitize it after the bounds
> check to avoid using it for speculative out-of-bounds access to arrays
> indexed by it.
>
> This addresses the following accesses detected with the help of smatch:
>
> * net/netlink/af_netlink.c:654 __netlink_create() warn: potential
> spectre issue 'nlk_cb_mutex_keys' [w]
>
> * net/netlink/af_netlink.c:654 __netlink_create() warn: potential
> spectre issue 'nlk_cb_mutex_key_strings' [w]
>
> * net/netlink/af_netlink.c:685 netlink_create() warn: potential spectre
> issue 'nl_table' [w] (local cap)
>
> Cc: Josh Poimboeuf <jpoimboe@redhat.com>
> Signed-off-by: Jeremy Cline <jcline@redhat.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2018-08-01 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 21:13 [PATCH] netlink: Fix spectre v1 gadget in netlink_create() Jeremy Cline
2018-07-31 21:23 ` Josh Poimboeuf
2018-08-01 16:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801.095135.79911181296177212.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jcline@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).