netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: petrm@mellanox.com
Cc: netdev@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kselftest@vger.kernel.org, corbet@lwn.net,
	jiri@mellanox.com, idosch@mellanox.com, kuznet@ms2.inr.ac.ru,
	yoshfuji@linux-ipv6.org, shuah@kernel.org,
	nikolay@cumulusnetworks.com, dsahern@gmail.com
Subject: Re: [PATCH net-next v2 0/7] ipv4: Control SKB reprioritization after forwarding
Date: Wed, 01 Aug 2018 09:52:54 -0700 (PDT)	[thread overview]
Message-ID: <20180801.095254.162481197087516714.davem@davemloft.net> (raw)
In-Reply-To: <cover.1533076217.git.petrm@mellanox.com>

From: Petr Machata <petrm@mellanox.com>
Date: Wed, 01 Aug 2018 00:35:53 +0200

> After IPv4 packets are forwarded, the priority of the corresponding SKB
> is updated according to the TOS field of IPv4 header. This overrides any
> prioritization done earlier by e.g. an skbedit action or ingress-qos-map
> defined at a vlan device.
> 
> Such overriding may not always be desirable. Even if the packet ends up
> being routed, which implies this is an L3 network node, an administrator
> may wish to preserve whatever prioritization was done earlier on in the
> pipeline.
> 
> Therefore this patch set introduces a sysctl that controls this
> behavior, net.ipv4.ip_forward_update_priority. It's value is 1 by
> default to preserve the current behavior.
> 
> All of the above is implemented in patch #1.
> 
> Value changes prompt a new NETEVENT_IPV4_FWD_UPDATE_PRIORITY_UPDATE
> notification, so that the drivers can hook up whatever logic may depend
> on this value. That is implemented in patch #2.
> 
> In patches #3 and #4, mlxsw is adapted to recognize the sysctl. On
> initialization, the RGCR register that handles router configuration is
> set in accordance with the sysctl. The new notification is listened to
> and RGCR is reconfigured as necessary.
> 
> In patches #5 to #7, a selftest is added to verify that mlxsw reflects
> the sysctl value as necessary. The test is expressed in terms of the
> recently-introduced ieee_setapp support, and works by observing how DSCP
> value gets rewritten depending on packet priority. For this reason, the
> test is added to the subdirectory drivers/net/mlxsw. Even though it's
> not particularly specific to mlxsw, it's not suitable for running on
> soft devices (which don't support the ieee_setapp et.al.).
 ...

Series applied, thank you.

      parent reply	other threads:[~2018-08-01 19:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31 22:35 [PATCH net-next v2 0/7] ipv4: Control SKB reprioritization after forwarding Petr Machata
2018-07-31 22:36 ` [PATCH net-next v2 1/7] net: " Petr Machata
2018-07-31 22:36 ` [PATCH net-next v2 2/7] net: ipv4: Notify about changes to ip_forward_update_priority Petr Machata
2018-07-31 22:37 ` [PATCH net-next v2 3/7] mlxsw: spectrum: Extract work-scheduling into a new function Petr Machata
2018-07-31 22:38 ` [PATCH net-next v2 4/7] mlxsw: spectrum_router: Handle sysctl_ip_fwd_update_priority Petr Machata
2018-07-31 22:38 ` [PATCH net-next v2 5/7] selftests: forwarding: Move lldpad waiting to lib.sh Petr Machata
2018-07-31 22:39 ` [PATCH net-next v2 6/7] selftests: forwarding: Move DSCP capture " Petr Machata
2018-07-31 22:39 ` [PATCH net-next v2 7/7] selftests: mlxsw: Add test for ip_forward_update_priority Petr Machata
2018-08-01 16:52 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180801.095254.162481197087516714.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=corbet@lwn.net \
    --cc=dsahern@gmail.com \
    --cc=idosch@mellanox.com \
    --cc=jiri@mellanox.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=petrm@mellanox.com \
    --cc=shuah@kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).