From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] inet/connection_sock: prefer _THIS_IP_ to
 current_text_addr
Date: Wed, 01 Aug 2018 18:42:08 -0700 (PDT)
Message-ID: <20180801.184208.776886134692058469.davem@davemloft.net>
References: <20180801215759.103758-1-ndesaulniers@google.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: natechancellor@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
To: ndesaulniers@google.com
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20180801215759.103758-1-ndesaulniers@google.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

From: Nick Desaulniers <ndesaulniers@google.com>
Date: Wed,  1 Aug 2018 14:57:59 -0700

> -			 sk, what, when, current_text_addr());
> +			 sk, what, when, (void *)_THIS_IP_);

Is a fugly macro in all caps really better than a function()?

I'm really surprised that _THIS_IP_ is being chosen over
current_text_addr(), seriously.