From: Jiri Pirko <jiri@resnulli.us>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
mlxsw@mellanox.com
Subject: Re: [patch net-next 2/2] net: sched: fix notifications for action-held chains
Date: Wed, 1 Aug 2018 11:24:31 +0200 [thread overview]
Message-ID: <20180801092431.GA2080@nanopsycho> (raw)
In-Reply-To: <CAM_iQpWp52KbTdvSNOX3jQn=Ttp9+CiZ3JkQE51jEfexaoPH6g@mail.gmail.com>
Wed, Aug 01, 2018 at 06:27:28AM CEST, xiyou.wangcong@gmail.com wrote:
>On Tue, Jul 31, 2018 at 5:10 AM Jiri Pirko <jiri@resnulli.us> wrote:
>>
>> From: Jiri Pirko <jiri@mellanox.com>
>>
>> Chains that only have action references serve as placeholders.
>> Until a non-action reference is created, user should not be aware
>> of the chain. Also he should not receive any notifications about it.
>> So send notifications for the new chain only in case the chain gets
>> the first non-action reference. Symmetrically to that, when
>> the last non-action reference is dropped, send the notification about
>> deleted chain.
>>
>> Reported-by: Cong Wang <xiyou.wangcong@gmail.com>
>> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>
>I think __tcf_chain_{get,put}() can be static.
In fact, tcf_chain_get/put could be now static too. Will send v2.
Thanks!
>
>Other than that,
>
>Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
>
>Thanks.
prev parent reply other threads:[~2018-08-01 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 12:07 [patch net-next 0/2] net: sched: couple of adjustments/fixes Jiri Pirko
2018-07-31 12:07 ` [patch net-next 1/2] net: sched: change name of zombie chain to "held_by_acts_only" Jiri Pirko
2018-08-01 4:26 ` Cong Wang
2018-07-31 12:07 ` [patch net-next 2/2] net: sched: fix notifications for action-held chains Jiri Pirko
2018-08-01 4:27 ` Cong Wang
2018-08-01 9:24 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801092431.GA2080@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).