From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next 2/2] net: sched: fix notifications for action-held chains Date: Wed, 1 Aug 2018 11:24:31 +0200 Message-ID: <20180801092431.GA2080@nanopsycho> References: <20180731120745.1230-1-jiri@resnulli.us> <20180731120745.1230-3-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux Kernel Network Developers , David Miller , Jamal Hadi Salim , Jakub Kicinski , mlxsw@mellanox.com To: Cong Wang Return-path: Received: from mail-wr1-f68.google.com ([209.85.221.68]:43948 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388972AbeHALMI (ORCPT ); Wed, 1 Aug 2018 07:12:08 -0400 Received: by mail-wr1-f68.google.com with SMTP id b15-v6so19382849wrv.10 for ; Wed, 01 Aug 2018 02:27:17 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Wed, Aug 01, 2018 at 06:27:28AM CEST, xiyou.wangcong@gmail.com wrote: >On Tue, Jul 31, 2018 at 5:10 AM Jiri Pirko wrote: >> >> From: Jiri Pirko >> >> Chains that only have action references serve as placeholders. >> Until a non-action reference is created, user should not be aware >> of the chain. Also he should not receive any notifications about it. >> So send notifications for the new chain only in case the chain gets >> the first non-action reference. Symmetrically to that, when >> the last non-action reference is dropped, send the notification about >> deleted chain. >> >> Reported-by: Cong Wang >> Signed-off-by: Jiri Pirko > >I think __tcf_chain_{get,put}() can be static. In fact, tcf_chain_get/put could be now static too. Will send v2. Thanks! > >Other than that, > >Acked-by: Cong Wang > >Thanks.