From: David Miller <davem@davemloft.net>
To: yuehaibing@huawei.com
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
lipeng321@huawei.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, shenjian15@huawei.com, joe@perches.com,
keescook@chromium.org, wangxi11@huawei.com
Subject: Re: [PATCH] net: hns: remove redundant variables 'max_frm' and 'tmp_mac_key'
Date: Thu, 02 Aug 2018 14:40:49 -0700 (PDT) [thread overview]
Message-ID: <20180802.144049.1566403478963516134.davem@davemloft.net> (raw)
In-Reply-To: <20180801101647.16968-1-yuehaibing@huawei.com>
From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 1 Aug 2018 18:16:47 +0800
> Variables 'max_frm' and 'tmp_mac_key' are being assigned,
> but are never used,hence they are redundant and can be removed.
>
> fix fllowing warning:
>
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c:461:6: warning: variable 'max_frm' set but not used [-Wunused-but-set-variable]
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:1685:31: warning: variable 'tmp_mac_key' set but not used [-Wunused-but-set-variable]
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:1855:41: warning: variable 'tmp_mac_key' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thank you.
prev parent reply other threads:[~2018-08-02 21:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 10:16 [PATCH] net: hns: remove redundant variables 'max_frm' and 'tmp_mac_key' YueHaibing
2018-08-02 21:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802.144049.1566403478963516134.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangxi11@huawei.com \
--cc=yisen.zhuang@huawei.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).