From: David Miller <davem@davemloft.net>
To: denis.bolotin@cavium.com
Cc: netdev@vger.kernel.org, ariel.elior@cavium.com
Subject: Re: [PATCH net-next v2 1/3] qed: Add DCBX API - qed_dcbx_get_priority_tc()
Date: Thu, 02 Aug 2018 14:46:34 -0700 (PDT) [thread overview]
Message-ID: <20180802.144634.28571912617151312.davem@davemloft.net> (raw)
In-Reply-To: <20180802081251.10003-2-denis.bolotin@cavium.com>
From: Denis Bolotin <denis.bolotin@cavium.com>
Date: Thu, 2 Aug 2018 11:12:49 +0300
> +int qed_dcbx_get_priority_tc(struct qed_hwfn *p_hwfn, u8 pri, u8 *p_tc)
Since the value range of the tc priority is 8-bit unsigned, you don't
need to return it by reference.
Simply return the value straight to the caller as an integer.
If it's negative, it has to be an error code. Otherwise it is
the value in question.
Thank you.
next prev parent reply other threads:[~2018-08-02 23:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 8:12 [PATCH net-next v2 0/3] qed: Add Multi-TC RoCE support Denis Bolotin
2018-08-02 8:12 ` [PATCH net-next v2 1/3] qed: Add DCBX API - qed_dcbx_get_priority_tc() Denis Bolotin
2018-08-02 21:46 ` David Miller [this message]
2018-08-02 8:12 ` [PATCH net-next v2 2/3] qed: Add a flag which indicates if offload TC is set Denis Bolotin
2018-08-02 8:12 ` [PATCH net-next v2 3/3] qed: Add Multi-TC RoCE support Denis Bolotin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802.144634.28571912617151312.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ariel.elior@cavium.com \
--cc=denis.bolotin@cavium.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).