From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v2 1/3] qed: Add DCBX API - qed_dcbx_get_priority_tc() Date: Thu, 02 Aug 2018 14:46:34 -0700 (PDT) Message-ID: <20180802.144634.28571912617151312.davem@davemloft.net> References: <20180802081251.10003-1-denis.bolotin@cavium.com> <20180802081251.10003-2-denis.bolotin@cavium.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, ariel.elior@cavium.com To: denis.bolotin@cavium.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:47740 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731429AbeHBXjh (ORCPT ); Thu, 2 Aug 2018 19:39:37 -0400 In-Reply-To: <20180802081251.10003-2-denis.bolotin@cavium.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Denis Bolotin Date: Thu, 2 Aug 2018 11:12:49 +0300 > +int qed_dcbx_get_priority_tc(struct qed_hwfn *p_hwfn, u8 pri, u8 *p_tc) Since the value range of the tc priority is 8-bit unsigned, you don't need to return it by reference. Simply return the value straight to the caller as an integer. If it's negative, it has to be an error code. Otherwise it is the value in question. Thank you.