From: Stephen Hemminger <stephen@networkplumber.org>
To: Peter Oskolkov <posk@google.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH v2 net-next 1/3] ip: discard IPv4 datagrams with overlapping segments.
Date: Thu, 2 Aug 2018 17:09:35 -0700 [thread overview]
Message-ID: <20180802170935.7ff9e4cb@xeon-e3> (raw)
In-Reply-To: <20180802233439.51643-2-posk@google.com>
On Thu, 2 Aug 2018 23:34:37 +0000
Peter Oskolkov <posk@google.com> wrote:
> This behavior is required in IPv6, and there is little need
> to tolerate overlapping fragments in IPv4. This change
> simplifies the code and eliminates potential DDoS attack vectors.
>
> Tested: ran ip_defrag selftest (not yet available uptream).
>
> Suggested-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Peter Oskolkov <posk@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Florian Westphal <fw@strlen.de>
There are a couple of relevant RFC's
RFC 1858 - Security Considerations for IP Fragment Filtering
RFC 2460 - Handling of Overlapping IPv6 Fragments
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2018-08-03 2:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 23:34 [PATCH v2 net-next 0/3] ip: Use rb trees for IP frag queue Peter Oskolkov
2018-08-02 23:34 ` [PATCH v2 net-next 1/3] ip: discard IPv4 datagrams with overlapping segments Peter Oskolkov
2018-08-03 0:09 ` Stephen Hemminger [this message]
2018-08-02 23:34 ` [PATCH v2 net-next 2/3] net: modify skb_rbtree_purge to return the truesize of all purged skbs Peter Oskolkov
2018-08-02 23:34 ` [PATCH v2 net-next 3/3] ip: use rb trees for IP frag queue Peter Oskolkov
2018-08-03 19:33 ` [PATCH v2 net-next 0/3] ip: Use " Josh Hunt
2018-08-03 19:57 ` Peter Oskolkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802170935.7ff9e4cb@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=posk@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox