From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH nf-next v2 1/1] ipv6: defrag: drop non-last frags
 smaller than min mtu
Date: Thu, 2 Aug 2018 17:14:03 -0700
Message-ID: <20180802171403.58a5e561@xeon-e3>
References: <20180803000539.17394-1-fw@strlen.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <netdev@vger.kernel.org>, Peter Oskolkov <posk@google.com>,
        Eric Dumazet <edumazet@google.com>
To: Florian Westphal <fw@strlen.de>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f174.google.com ([209.85.215.174]:41835 "EHLO
        mail-pg1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727161AbeHCCHp (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 2 Aug 2018 22:07:45 -0400
Received: by mail-pg1-f174.google.com with SMTP id z8-v6so1966446pgu.8
        for <netdev@vger.kernel.org>; Thu, 02 Aug 2018 17:14:11 -0700 (PDT)
In-Reply-To: <20180803000539.17394-1-fw@strlen.de>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri,  3 Aug 2018 02:05:39 +0200
Florian Westphal <fw@strlen.de> wrote:

> +	if (-skb_network_offset(skb) + skb->len < IPV6_MIN_MTU &&

Is there a reason to write the arithmetic expression in this order?
Why not:
	if (skb->len - skb_network_offset(skb) < IPV6_MIN_MTU &&