From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/3] l2tp: sanitise MTU handling on sessions Date: Fri, 03 Aug 2018 10:04:22 -0700 (PDT) Message-ID: <20180803.100422.716736599661874064.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jchapman@katalix.com To: g.nault@alphalink.fr Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:35462 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727171AbeHCTBc (ORCPT ); Fri, 3 Aug 2018 15:01:32 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Guillaume Nault Date: Fri, 3 Aug 2018 12:38:32 +0200 > Most of the code handling sessions' MTU has no effect. The ->mtu field > in struct l2tp_session might be used at session creation time, but > neither PPP nor Ethernet pseudo-wires take updates into account. > > L2TP sessions don't have a concept of MTU, which is the reason why > ->mtu is mostly ignored. MTU should remain a network device thing. > Therefore this patch set does not try to propagate/update ->mtu to/from > the device. That would complicate the code unnecessarily. Instead this > field and the associated ioctl commands and netlink attributes are > removed. > > Patch #1 defines l2tp_tunnel_dst_mtu() in order to simplify the > following patches. Then patches #2 and #3 remove MTU handling from PPP > and Ethernet pseudo-wires respectively. Series applied, thanks.