Re: [PATCH nf-next v2 1/1] ipv6: defrag: drop non-last frags smaller than min mtu

Stephen Hemminger
2018-08-03T02:07:45Z

On Fri, 3 Aug 2018 02:05:39 +0200
Florian Westphal <fw@strlen.de> wrote:

> + if (-skb_network_offset(skb) + skb->len < IPV6_MIN_MTU &&

Is there a reason to write the arithmetic expression in this order?
Why not:
if (skb->len - skb_network_offset(skb) < IPV6_MIN_MTU &&