From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Subject: Re: [PATCH] ppp: mppe: Remove VLA usage Date: Fri, 3 Aug 2018 13:13:15 +1000 Message-ID: <20180803031315.GA30807@fergus> References: <20180716040516.GA32783@beast> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Arnd Bergmann , "David S. Miller" , Herbert Xu , Eric Biggers , "Gustavo A. R. Silva" , linux-ppp@vger.kernel.org, Networking , Linux Kernel Mailing List To: Kees Cook Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, Aug 02, 2018 at 04:27:01PM -0700, Kees Cook wrote: > On Mon, Jul 16, 2018 at 4:01 AM, Arnd Bergmann wrote: > > On Mon, Jul 16, 2018 at 6:05 AM, Kees Cook wrote: > >> In the quest to remove all stack VLA usage from the kernel[1], this > >> removes the discouraged use of AHASH_REQUEST_ON_STACK (and associated > >> VLA) by switching to shash directly and keeping the associated descriptor > >> allocated with the regular state on the heap. > >> > >> [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com > >> > >> Signed-off-by: Kees Cook > > > > I had concerns at first that this approach might make it slower, but > > upon reading through implementation of the shash_ahash_ implementation, > > I concluded that it can only be better than before, improving both > > performance and stack usage. > > > > Acked-by: Arnd Bergmann > > Paul, > > Is this something you can take via your tree? No, it would go via the netdev tree, I expect. Paul.