From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [PATCH v8 bpf-next 04/10] xdp: Helper function to clear kernel pointers in xdp_frame Date: Fri, 3 Aug 2018 11:06:10 +0200 Message-ID: <20180803110610.5f3235f8@redhat.com> References: <1533283098-2397-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> <1533283098-2397-5-git-send-email-makita.toshiaki@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, Jakub Kicinski , John Fastabend , brouer@redhat.com To: Toshiaki Makita Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35270 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728450AbeHCLBi (ORCPT ); Fri, 3 Aug 2018 07:01:38 -0400 In-Reply-To: <1533283098-2397-5-git-send-email-makita.toshiaki@lab.ntt.co.jp> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 3 Aug 2018 16:58:12 +0900 Toshiaki Makita wrote: > xdp_frame has kernel pointers which should not be readable from bpf > programs. When we want to reuse xdp_frame region but it may be read by > bpf programs later, we can use this helper to clear kernel pointers. > This is more efficient than calling memset() for the entire struct. > > Signed-off-by: Toshiaki Makita Acked-by: Jesper Dangaard Brouer After this patch is applied, I will take care of updating cpumap in a similar way. Thanks. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer