From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [PATCH v8 bpf-next 05/10] veth: Handle xdp_frames in xdp napi ring Date: Fri, 3 Aug 2018 11:07:10 +0200 Message-ID: <20180803110710.3b474b83@redhat.com> References: <1533283098-2397-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> <1533283098-2397-6-git-send-email-makita.toshiaki@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, Jakub Kicinski , John Fastabend , brouer@redhat.com To: Toshiaki Makita Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:45378 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728450AbeHCLCg (ORCPT ); Fri, 3 Aug 2018 07:02:36 -0400 In-Reply-To: <1533283098-2397-6-git-send-email-makita.toshiaki@lab.ntt.co.jp> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 3 Aug 2018 16:58:13 +0900 Toshiaki Makita wrote: > This is preparation for XDP TX and ndo_xdp_xmit. > This allows napi handler to handle xdp_frames through xdp ring as well > as sk_buff. > > v8: > - Don't use xdp_frame pointer address to calculate skb->head and > headroom. > > v7: > - Use xdp_scrub_frame() instead of memset(). > > v3: > - Revert v2 change around rings and use a flag to differentiate skb and > xdp_frame, since bulk skb xmit makes little performance difference > for now. > > v2: > - Use another ring instead of using flag to differentiate skb and > xdp_frame. This approach makes bulk skb transmit possible in > veth_xmit later. > - Clear xdp_frame feilds in skb->head. > - Implement adjust_tail. > > Signed-off-by: Toshiaki Makita > Acked-by: John Fastabend Acked-by: Jesper Dangaard Brouer Thanks this looks much better. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer